Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creates MVP for new buy/sell UI #2706

Merged
merged 16 commits into from
Aug 14, 2024

Conversation

jeeanribeiro
Copy link
Member

@jeeanribeiro jeeanribeiro commented Jul 3, 2024

Summary

closes #2590

Testing

Needs to have TRANSAK_API_KEY env variable defined

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch 2 times, most recently from e3e842e to 4fd44e0 Compare July 3, 2024 05:53
@jeeanribeiro jeeanribeiro self-assigned this Jul 3, 2024
@jeeanribeiro jeeanribeiro linked an issue Jul 3, 2024 that may be closed by this pull request
Base automatically changed from refactor/market-currency to develop July 3, 2024 07:10
@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch 4 times, most recently from 354dabc to fa5248d Compare July 8, 2024 01:24
@jeeanribeiro jeeanribeiro marked this pull request as ready for review July 8, 2024 01:25
@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch 4 times, most recently from 1a317d4 to e7e8d4d Compare July 11, 2024 22:40
@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch from e7e8d4d to 9101715 Compare July 15, 2024 12:49
@jeeanribeiro jeeanribeiro marked this pull request as draft July 16, 2024 14:20
@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch from 684f2bb to 52ec506 Compare July 17, 2024 12:24
jeeanribeiro and others added 7 commits July 18, 2024 20:23
* feat: adds multichain support in BuySell view

* refactor: use network id on transak cryptocurrency

Co-authored-by: Jean Ribeiro <[email protected]>

* use id in token popup filter

* enable buy sell on all profiles

* add network into transak crypto currencies

* dynamically pull in transak cryptos based of profile networks

* enhancment: sort transak cryptos

---------

Co-authored-by: Nicole O'Brien <[email protected]>
* WIP

* chore: fix reactivity and organize code

* chore: fix selected cryptocurrency & increase exchange panel height

* feat: add RecipientInput

---------

Co-authored-by: Nicole O'Brien <[email protected]>
@jeeanribeiro jeeanribeiro force-pushed the 2590----create-buysell-exchange-ui branch from 21435aa to 38c0523 Compare July 18, 2024 23:24
jeeanribeiro and others added 2 commits July 23, 2024 14:00
* feat: Transak window as a Popup

* refactor: change TransakConnectionPanel to be a popup banner

* fix: disable button if necessary

* fix: adds locale strings in quotations panel

* fix: makes TransakFramePopup props optional

* enhancement: sets error to true if any of the props in falsy
* feat: adds buy/sell quotations timer

* fix: quote timer logic

Co-authored-by: Jean Ribeiro <[email protected]>

* refactor: cleanup quote loading state

---------

Co-authored-by: Nicole O'Brien <[email protected]>
nicole-obrien and others added 7 commits August 6, 2024 10:49
…rder (#2760)

* enhancement: adds payment methods localization

* fix: remove array of undefined in quotes

* fix: getComputedStyle error and iframe out of bounds

* chore: update bloom ui kit version

---------

Co-authored-by: Nicole O'Brien <[email protected]>
* feat: adds min and max amount in TransakAmountInput

* fix: logic so that no quotes are generated when value is outside min or max

Co-authored-by: Jean Ribeiro <[email protected]>

---------

Co-authored-by: Nicole O'Brien <[email protected]>
* fix: only show currencies that have payment method available

* feat: adds TransakCryptoCurrencyTile variant

* feat: adds view title

* feat: adds colors to tokens network pills

* fix: prevent selected currency option undefined error

* feat: adds EmptyListPlaceholder in TransakExchangePanel

* refactor: uses transak api base url depending on profile network

* fix: undefined currency

* feat: adds transak widget url for testnet and mainnet

* fix: quotations positioning

* feat: updates ui kit and adds Pill colors

* chore: inverts TransakCryptoCurrencyAmountTile amounts position

* refactor: create network name pill component

* ui: fix transak frame height

* refactor: organise transak query params, enable transak menu

* refactor: rename transak quotation tile

* fix: iota showing on buy sell for mainnet profiles

* ui: dont capitalise names on network pill

---------

Co-authored-by: Nicole O'Brien <[email protected]>
@jeeanribeiro jeeanribeiro marked this pull request as ready for review August 13, 2024 14:48
@jeeanribeiro jeeanribeiro enabled auto-merge (squash) August 13, 2024 22:42
@jeeanribeiro jeeanribeiro merged commit ce8cc98 into develop Aug 14, 2024
7 checks passed
@jeeanribeiro jeeanribeiro deleted the 2590----create-buysell-exchange-ui branch August 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 - Create buy/sell exchange UI
2 participants