-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creates MVP for new buy/sell UI #2706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
2 times, most recently
from
July 3, 2024 05:53
e3e842e
to
4fd44e0
Compare
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
4 times, most recently
from
July 8, 2024 01:24
354dabc
to
fa5248d
Compare
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
4 times, most recently
from
July 11, 2024 22:40
1a317d4
to
e7e8d4d
Compare
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
from
July 15, 2024 12:49
e7e8d4d
to
9101715
Compare
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
from
July 17, 2024 12:24
684f2bb
to
52ec506
Compare
* feat: adds multichain support in BuySell view * refactor: use network id on transak cryptocurrency Co-authored-by: Jean Ribeiro <[email protected]> * use id in token popup filter * enable buy sell on all profiles * add network into transak crypto currencies * dynamically pull in transak cryptos based of profile networks * enhancment: sort transak cryptos --------- Co-authored-by: Nicole O'Brien <[email protected]>
* WIP * chore: fix reactivity and organize code * chore: fix selected cryptocurrency & increase exchange panel height * feat: add RecipientInput --------- Co-authored-by: Nicole O'Brien <[email protected]>
jeeanribeiro
force-pushed
the
2590----create-buysell-exchange-ui
branch
from
July 18, 2024 23:24
21435aa
to
38c0523
Compare
* feat: Transak window as a Popup * refactor: change TransakConnectionPanel to be a popup banner * fix: disable button if necessary * fix: adds locale strings in quotations panel * fix: makes TransakFramePopup props optional * enhancement: sets error to true if any of the props in falsy
* feat: adds buy/sell quotations timer * fix: quote timer logic Co-authored-by: Jean Ribeiro <[email protected]> * refactor: cleanup quote loading state --------- Co-authored-by: Nicole O'Brien <[email protected]>
Co-authored-by: Nicole O'Brien <[email protected]>
…rder (#2760) * enhancement: adds payment methods localization * fix: remove array of undefined in quotes * fix: getComputedStyle error and iframe out of bounds * chore: update bloom ui kit version --------- Co-authored-by: Nicole O'Brien <[email protected]>
* feat: adds min and max amount in TransakAmountInput * fix: logic so that no quotes are generated when value is outside min or max Co-authored-by: Jean Ribeiro <[email protected]> --------- Co-authored-by: Nicole O'Brien <[email protected]>
* fix: only show currencies that have payment method available * feat: adds TransakCryptoCurrencyTile variant * feat: adds view title * feat: adds colors to tokens network pills * fix: prevent selected currency option undefined error * feat: adds EmptyListPlaceholder in TransakExchangePanel * refactor: uses transak api base url depending on profile network * fix: undefined currency * feat: adds transak widget url for testnet and mainnet * fix: quotations positioning * feat: updates ui kit and adds Pill colors * chore: inverts TransakCryptoCurrencyAmountTile amounts position * refactor: create network name pill component * ui: fix transak frame height * refactor: organise transak query params, enable transak menu * refactor: rename transak quotation tile * fix: iota showing on buy sell for mainnet profiles * ui: dont capitalise names on network pill --------- Co-authored-by: Nicole O'Brien <[email protected]>
nicole-obrien
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2590
Testing
Needs to have TRANSAK_API_KEY env variable defined
Platforms
Checklist